Added windows support for libwhisper bindings#92
Merged
Conversation
Closed
Closed
There was a problem hiding this comment.
Pull request overview
Adds Windows support for the sys/whisper CGO bindings by introducing Windows-specific pkg-config integration and generation of a corresponding .pc file.
Changes:
- Added a Windows-specific
#cgo windows pkg-config: libwhisper-windowsdirective. - Added a
go:generatecommand to producelibwhisper-windows.pcwith Windows linker flags.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
machayka
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds Windows support to the
whisperpackage by introducing Windows-specific build and pkg-config directives insys/whisper/generate.go.Platform support:
#cgodirective for linking againstlibwhisper-windowsingenerate.go.go:generatecommand for generating Windows-specific pkg-config files and linking instructions ingenerate.go.Thanks to @machayka