Conversation
There was a problem hiding this comment.
Pull request overview
This pull request fixes the CUDA build configuration by correcting how the CMAKE_CUDA_ARCHITECTURES CMake flag is quoted in the Makefile. The changes ensure proper handling of semicolons as CMake list separators and prevent unintended shell interpretation.
Changes:
- Updated quoting style for
CMAKE_CUDA_ARCHITECTURESfrom double quotes around values to single quotes around the entire flag - Removed backslash escaping of semicolons in the architecture list for amd64 builds, relying on single quotes for literal interpretation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a minor adjustment to the CUDA build configuration in the
Makefile. The change updates how theCMAKE_CUDA_ARCHITECTURESargument is passed to ensure proper handling of semicolons and quoting in CMake flags.Makefile: Changed the wayCMAKE_CUDA_ARCHITECTURESis quoted and passed inCMAKE_FLAGSfor botharm64andamd64CUDA builds, improving compatibility with CMake argument parsing.