Merged
Conversation
Member
djthorpe
commented
Jun 18, 2025
- Added translation for gowhisper
- Removed some debugging
- Added a 404 handler for unmatched requests
There was a problem hiding this comment.
Pull Request Overview
This PR reintroduces translation support for the gowhisper client, removes leftover debug logging, and adds a catch-all 404 handler at the root path.
- Renames
gowhisperfield inoptstotranscribe, adds a newtranslatefield, and updates option setters. - Re-enables
c.gowhisper.Translateinclient.goand removes outdated commented blocks. - Removes debug
fmt.Printlncalls and registers a root-level 404 handler in the API router.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| third_party/whisper.cpp | Updated submodule commit reference |
| pkg/client/opts.go | Renamed opts fields and extended option functions for translation |
| pkg/client/gowhisper/schema.go | Added Stream field to TranslationRequest schema |
| pkg/client/client.go | Hooked up Translate call on gowhisper client and updated request usage |
| pkg/api/transcribe.go | Removed debug fmt import and print statements |
| pkg/api/register.go | Added a root / handler to return a 404 response |
Comments suppressed due to low confidence (2)
pkg/client/opts.go:23
- [nitpick] Consider renaming the opts struct fields to consistent noun-based names, e.g.,
transcriptionandtranslation, for clearer symmetry between the two operations.
transcribe gowhisper.TranscriptionRequest
pkg/api/register.go:30
- [nitpick] Avoid manually closing the request body in HTTP handlers; the Go net/http server automatically closes
r.Bodyafter the handler returns.
defer r.Body.Close()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.