Skip to content

improvement: convert anyhow to thiserror errors#521

Merged
Wodann merged 1 commit intomun-lang:mainfrom
Wodann:improvement/errors
May 14, 2023
Merged

improvement: convert anyhow to thiserror errors#521
Wodann merged 1 commit intomun-lang:mainfrom
Wodann:improvement/errors

Conversation

@Wodann
Copy link
Copy Markdown
Collaborator

@Wodann Wodann commented May 9, 2023

To Do:

  • rebase

@Wodann Wodann added the type: perf Changes that improve performance label May 9, 2023
@Wodann Wodann requested a review from baszalmstra May 9, 2023 03:13
@Wodann Wodann self-assigned this May 9, 2023
@Wodann Wodann added this to the Mun v0.5.0 milestone May 9, 2023
baszalmstra
baszalmstra approved these changes May 10, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@baszalmstra baszalmstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing! Thanks so much!

@Wodann Wodann force-pushed the improvement/errors branch from bde3ec5 to e83e7fc Compare May 14, 2023 22:33
@codecov
Copy link
Copy Markdown

codecov bot commented May 14, 2023

Codecov Report

Merging #521 (e83e7fc) into main (95a9612) will decrease coverage by 2.94%.
The diff coverage is 80.41%.

@@            Coverage Diff             @@
##             main     #521      +/-   ##
==========================================
- Coverage   87.16%   84.23%   -2.94%     
==========================================
  Files         274      274              
  Lines       31022    31026       +4     
==========================================
- Hits        27041    26135     -906     
- Misses       3981     4891     +910
Impacted Files Coverage Δ
crates/mun_memory/src/lib.rs 50.00% <0.00%> (ø)
crates/mun_memory/src/type/mod.rs 88.88% <ø> (ø)
crates/mun_runtime/src/lib.rs 75.05% <76.47%> (+0.75%) ⬆️
crates/mun_runtime/src/assembly.rs 92.33% <78.57%> (+3.44%) ⬆️
crates/mun_libloader/src/temp_library.rs 93.33% <83.33%> (-6.67%) ⬇️
crates/mun_libloader/src/lib.rs 97.95% <91.66%> (-2.05%) ⬇️
...rates/mun_codegen/src/code_gen/assembly_builder.rs 100.00% <100.00%> (ø)
crates/mun_codegen/src/code_gen/symbols/mod.rs 98.05% <100.00%> (-1.52%) ⬇️
crates/mun_test/src/driver.rs 83.47% <100.00%> (-4.14%) ⬇️

... and 9 files with indirect coverage changes

@Wodann Wodann force-pushed the improvement/errors branch from e83e7fc to d9232b5 Compare May 14, 2023 23:34
@Wodann Wodann merged commit cbb482e into mun-lang:main May 14, 2023
@Wodann Wodann deleted the improvement/errors branch May 14, 2023 23:34
@Wodann Wodann added type: refactor Refactor existing code and removed type: perf Changes that improve performance labels Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@baszalmstra baszalmstra baszalmstra approved these changes

Assignees

@Wodann Wodann

Labels

type: refactor Refactor existing code

Projects

None yet

Milestone

Mun v0.5.0

Development

Successfully merging this pull request may close these issues.

2 participants

@Wodann @baszalmstra