Skip to content

bump: llvm from 13 to 14#495

Merged
baszalmstra merged 10 commits intomun-lang:mainfrom
baszalmstra:bump/llvm_14
Jan 4, 2023
Merged

bump: llvm from 13 to 14#495
baszalmstra merged 10 commits intomun-lang:mainfrom
baszalmstra:bump/llvm_14

Conversation

@baszalmstra
Copy link
Copy Markdown
Collaborator

@baszalmstra baszalmstra commented Dec 12, 2022

Bump LLVM from 13 to 14.

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 2, 2023 •
edited
Loading

Codecov Report

Merging #495 (4a9ed64) into main (a3025a7) will decrease coverage by 0.07%.
The diff coverage is 52.38%.

@@            Coverage Diff             @@
##             main     #495      +/-   ##
==========================================
- Coverage   87.17%   87.09%   -0.08%     
==========================================
  Files         275      274       -1     
  Lines       31046    31082      +36     
==========================================
+ Hits        27064    27071       +7     
- Misses       3982     4011      +29
Impacted Files Coverage Δ
crates/mun_target/src/spec.rs 89.74% <ø> (-0.26%) ⬇️
crates/mun_target/src/spec/aarch64_apple_darwin.rs 0.00% <0.00%> (ø)
crates/mun_target/src/spec/aarch64_apple_ios.rs 0.00% <0.00%> (ø)
...rates/mun_target/src/spec/aarch64_apple_ios_sim.rs 0.00% <0.00%> (ø)
crates/mun_target/src/spec/x86_64_apple_ios.rs 0.00% <0.00%> (ø)
crates/mun_target/src/spec/apple_base.rs 53.47% <51.45%> (-5.36%) ⬇️
crates/mun_codegen/src/linker.rs 88.70% <100.00%> (+2.21%) ⬆️
crates/mun_target/src/spec/x86_64_apple_darwin.rs 100.00% <100.00%> (ø)
...ates/mun_target/src/spec/x86_64_pc_windows_msvc.rs 100.00% <100.00%> (ø)
...es/mun_target/src/spec/x86_64_unknown_linux_gnu.rs 100.00% <100.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Wodann
Wodann reviewed Jan 3, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Wodann Wodann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just make sure to also add a changelog :)

@baszalmstra
Copy link
Copy Markdown
Collaborator Author

baszalmstra commented Jan 3, 2023

Thanks I modified the changelog.

To get this to work on macOS I had to refactor the apple targets again a little bit. I think they are actually simpler now. It works on my old x86_64 MacBook but I don't have access to an M1. Would you be able to run the tests locally @Wodann ?

@Wodann
Copy link
Copy Markdown
Collaborator

Wodann commented Jan 3, 2023

To get this to work on macOS I had to refactor the apple targets again a little bit. I think they are actually simpler now. It works on my old x86_64 MacBook but I don't have access to an M1. Would you be able to run the tests locally @Wodann ?

Yup, I'll checkout your branch and run it 🙂

Wodann
Wodann reviewed Jan 4, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Wodann Wodann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my M1 and LGTM!

@baszalmstra
Copy link
Copy Markdown
Collaborator Author

baszalmstra commented Jan 4, 2023

I released lld-rs for LLD 14 and updated the dependency in this branch. If CI succeeds we can merge.

@baszalmstra baszalmstra merged commit 73b1347 into mun-lang:main Jan 4, 2023
@baszalmstra baszalmstra mentioned this pull request Jan 4, 2023
Closed
@Wodann Wodann added this to the Mun v0.5.0 milestone Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Wodann Wodann Wodann approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Mun v0.5.0

Development

Successfully merging this pull request may close these issues.

2 participants

@baszalmstra @Wodann