feat: add Type API to mitigate issues around memory#427
Merged
Wodann merged 16 commits intomun-lang:mainfrom Aug 6, 2022
Merged
feat: add Type API to mitigate issues around memory#427Wodann merged 16 commits intomun-lang:mainfrom
Type API to mitigate issues around memory#427Wodann merged 16 commits intomun-lang:mainfrom
Conversation
Wodann
requested changes
Jul 24, 2022
Codecov Report
@@ Coverage Diff @@
## main #427 +/- ##
==========================================
+ Coverage 83.04% 83.13% +0.08%
==========================================
Files 280 281 +1
Lines 16520 16648 +128
==========================================
+ Hits 13719 13840 +121
- Misses 2801 2808 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. |
Wodann
requested changes
Aug 6, 2022
Wodann
approved these changes
Aug 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the Type system. It exposes only:
Typewhich is now your one and only handle for type information. Internally it uses reference counting and a system to ensure that cross-referencing types are not deallocated.I also had to rewrite the FFI code for types because of this so I also made all the FFI code and tests a little more ergonomic/easy to use.
The only thing missing currently is the C++ code that accompanies the changes.
This does fix issue #423 .
Closes #423