Make TypeId as a key of TypeInfo#415
Merged
baszalmstra merged 17 commits intomun-lang:mainfrom Jul 7, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #415 +/- ##
==========================================
- Coverage 83.81% 83.68% -0.14%
==========================================
Files 273 276 +3
Lines 16179 16405 +226
==========================================
+ Hits 13560 13728 +168
- Misses 2619 2677 +58
Continue to review full report at Codecov.
|
Wodann
requested changes
Jul 3, 2022
Collaborator
Wodann
left a comment
There was a problem hiding this comment.
First full pass on review is done
Collaborator
Author
|
I updated the c++ code as well! This all seems to pass CI now too! Can you check the comments I responded to @Wodann ? Im still planning on adding a few tests here and there. |
Wodann
requested changes
Jul 7, 2022
Collaborator
Author
|
I fixed some of your final comments, it looks good to me too! @Wodann can you please review my last comments and code? If you're in agreement, feel free to merge! :) |
Wodann
approved these changes
Jul 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to simplify the runtime and ABI by removing the use of
TypeIdin several places and only usingArc<TypeInfo>. This should enable adding pointer type TypeIds.The idea is that some types are "concrete" which means they are concrete types like a struct or primitive. Pointers (and later arrays) are not concrete types but instead refer indirectly to concrete types.
The tests for the ABI and memory crate succeed, next up is modifying the compiler.