fix: dont use a shared type for typeinfo strong count#407
Merged
baszalmstra merged 1 commit intomun-lang:mainfrom Jun 1, 2022
Merged
fix: dont use a shared type for typeinfo strong count#407baszalmstra merged 1 commit intomun-lang:mainfrom
baszalmstra merged 1 commit intomun-lang:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #407 +/- ##
==========================================
+ Coverage 83.78% 83.81% +0.03%
==========================================
Files 273 273
Lines 16192 16179 -13
==========================================
- Hits 13566 13560 -6
+ Misses 2626 2619 -7
Continue to review full report at Codecov.
|
Wodann
approved these changes
Jun 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a strange error only when running tarpaulin in CI.
I think the issue has something to do with using a shared TypeInfo. The
strong_countof anArcis not safe to use across multiple threads because other threads might modify the value.This is an attempt to fix this issue by creating a struct type in the runtime which should have a unique TypeInfo for the thread running .