Skip to content

refactor: move lld-rs to seperate repository#373

Merged
Wodann merged 2 commits intomun-lang:mainfrom
baszalmstra:refactor/move_lld_to_own_repo
May 14, 2022
Merged

refactor: move lld-rs to seperate repository#373
Wodann merged 2 commits intomun-lang:mainfrom
baszalmstra:refactor/move_lld_to_own_repo

Conversation

@baszalmstra
Copy link
Copy Markdown
Collaborator

Move LLD to its own repository so we (but mostly other folks) can progress its version regardless of the main Mun repository.

The new location for the renamed library (lld-rs instead of mun-lld) can be found here: https://github.com/mun-lang/lld-rs

Fixes: #353

@baszalmstra
Copy link
Copy Markdown
Collaborator Author

Im just double checking that mun still builds when using the external repository before I publish lld-rs.

@ghaith I created a new repository from the mun repository where I rewrote most of history. I credited you in a few of the commits with improvements you made. I hope that's ok?

@ghaith
Copy link
Copy Markdown

ghaith commented May 14, 2022

Yes sounds good to me. Thanks.

@baszalmstra baszalmstra force-pushed the refactor/move_lld_to_own_repo branch from 4dd3aa6 to 124eeba Compare May 14, 2022 16:51
@codecov
Copy link
Copy Markdown

codecov bot commented May 14, 2022

Codecov Report

Merging #373 (ebca466) into main (cdfda48) will increase coverage by 0.07%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main     #373      +/-   ##
==========================================
+ Coverage   82.54%   82.61%   +0.07%     
==========================================
  Files         264      262       -2     
  Lines       15248    15219      -29     
==========================================
- Hits        12586    12573      -13     
+ Misses       2662     2646      -16     
Impacted Files Coverage Δ
crates/mun_codegen/src/linker.rs 25.33% <33.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdfda48...ebca466. Read the comment docs.

@baszalmstra baszalmstra marked this pull request as ready for review May 14, 2022 17:27
@Wodann Wodann merged commit dbde905 into mun-lang:main May 14, 2022
@Wodann Wodann added this to the Mun v0.4.0 milestone Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reusing mun_lld

3 participants