Skip to content

feat: make the runtime send#370

Merged
Wodann merged 1 commit intomun-lang:mainfrom
baszalmstra:feat/make_send
Feb 28, 2022
Merged

feat: make the runtime send#370
Wodann merged 1 commit intomun-lang:mainfrom
baszalmstra:feat/make_send

Conversation

@baszalmstra
Copy link
Copy Markdown
Collaborator

Removes the need to put the Runtime into a Rc<RefCell<Runtime>>. This makes the Runtime Send.

Closes #299

@baszalmstra baszalmstra added the type: perf Changes that improve performance label Feb 27, 2022
@baszalmstra baszalmstra added this to the Mun v0.4.0 milestone Feb 27, 2022
@baszalmstra baszalmstra requested a review from Wodann February 27, 2022 16:46
@baszalmstra baszalmstra self-assigned this Feb 27, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 27, 2022

Codecov Report

Merging #370 (857bcae) into main (3a481eb) will increase coverage by 0.00%.
The diff coverage is 94.87%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #370   +/-   ##
=======================================
  Coverage   82.53%   82.54%           
=======================================
  Files         264      264           
  Lines       15287    15247   -40     
=======================================
- Hits        12617    12585   -32     
+ Misses       2670     2662    -8     
Impacted Files Coverage Δ
crates/mun/src/ops/start.rs 0.00% <0.00%> (ø)
crates/mun_runtime/benches/util/mod.rs 0.00% <0.00%> (ø)
crates/mun_runtime/tests/hot_reloading.rs 100.00% <ø> (ø)
crates/mun_runtime/src/lib.rs 68.65% <66.66%> (-0.16%) ⬇️
crates/mun/tests/integration.rs 100.00% <100.00%> (ø)
crates/mun_memory/src/gc/root_ptr.rs 66.66% <100.00%> (+3.50%) ⬆️
crates/mun_runtime/src/adt.rs 78.70% <100.00%> (+2.70%) ⬆️
crates/mun_runtime/tests/marshalling.rs 98.20% <100.00%> (-0.07%) ⬇️
crates/mun_runtime/tests/memory.rs 100.00% <100.00%> (ø)
crates/mun_runtime/tests/runtime.rs 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a481eb...857bcae. Read the comment docs.

@Wodann Wodann merged commit b74092a into mun-lang:main Feb 28, 2022
@Wodann Wodann added type: feat New feature or request and removed type: perf Changes that improve performance labels Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: feat New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using Mun in a threaded environment

2 participants