Skip to content

fix(parser): add semicolon to declaration recovery set#365

Merged
Wodann merged 1 commit intomun-lang:mainfrom
jonatcln:fix/update-recovery-set
Feb 10, 2022
Merged

fix(parser): add semicolon to declaration recovery set#365
Wodann merged 1 commit intomun-lang:mainfrom
jonatcln:fix/update-recovery-set

Conversation

@jonatcln
Copy link
Copy Markdown
Contributor

@jonatcln jonatcln commented Feb 1, 2022

Example of a problem this fixes:

use;
pub fn main() {}

Original output:

error: syntax error
 --> mod.mun:1:4
  |
1 | use;
  |    ^ expected one of `self`, `super`, `package` or an identifier
  |error: syntax error
 --> mod.mun:1:5
  |
1 | use;
  |     ^ expected SEMI
  |

Output after fix:

error: syntax error
 --> mod.mun:1:4
  |
1 | use;
  |    ^ expected one of `self`, `super`, `package` or an identifier
  |

@baszalmstra baszalmstra self-requested a review February 9, 2022 12:37
baszalmstra
baszalmstra approved these changes Feb 9, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@baszalmstra baszalmstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one too! The CI should be fixed with #366, once that's merged could you rebase your changes on the latest main? Ill drop a comment here once that happens.

@baszalmstra
Copy link
Copy Markdown
Collaborator

baszalmstra commented Feb 9, 2022

Yes! #366 has been merged! Could you rebase on main? Should fix the CI!

@jonatcln jonatcln force-pushed the fix/update-recovery-set branch from 79501f1 to 1e83362 Compare February 10, 2022 08:31
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 10, 2022

Codecov Report

Merging #365 (1e83362) into main (6fa4e7b) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #365      +/-   ##
==========================================
- Coverage   82.63%   82.63%   -0.01%     
==========================================
  Files         264      264              
  Lines       15297    15297              
==========================================
- Hits        12641    12640       -1     
- Misses       2656     2657       +1
Impacted Files Coverage Δ
...tes/mun_syntax/src/parsing/grammar/declarations.rs 96.15% <ø> (ø)
crates/mun_hir/src/ty/infer/type_variable.rs 80.35% <0.00%> (-0.90%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fa4e7b...1e83362. Read the comment docs.

@jonatcln
Copy link
Copy Markdown
Contributor Author

jonatcln commented Feb 10, 2022

Rebased!

@Wodann Wodann merged commit c970d80 into mun-lang:main Feb 10, 2022
@jonatcln jonatcln deleted the fix/update-recovery-set branch February 10, 2022 14:21
@Wodann Wodann added this to the Mun v0.4.0 milestone Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@baszalmstra baszalmstra baszalmstra approved these changes

Assignees

@jonatcln jonatcln

Labels

None yet

Projects

None yet

Milestone

Mun v0.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@jonatcln @baszalmstra @Wodann