Skip to content

fix: locate sdkroot required since big sur#362

Merged
baszalmstra merged 1 commit intomun-lang:mainfrom
baszalmstra:fix/macos_big_sur
Jan 23, 2022
Merged

fix: locate sdkroot required since big sur#362
baszalmstra merged 1 commit intomun-lang:mainfrom
baszalmstra:fix/macos_big_sur

Conversation

@baszalmstra
Copy link
Copy Markdown
Collaborator

Apparently, since macOS Big Sur the location of system libraries moved. We now need to explicitly specify where to find these. I used the same technique used by Rust to locate this path.

Closes #361

@baszalmstra baszalmstra added the type: fix Bug fix or report label Jan 23, 2022
@baszalmstra baszalmstra requested a review from Wodann January 23, 2022 19:15
@baszalmstra baszalmstra self-assigned this Jan 23, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 23, 2022

Codecov Report

Merging #362 (58ff15c) into main (72dd828) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #362      +/-   ##
==========================================
- Coverage   82.65%   82.56%   -0.10%     
==========================================
  Files         263      264       +1     
  Lines       15217    15234      +17     
==========================================
  Hits        12578    12578              
- Misses       2639     2656      +17     
Impacted Files Coverage Δ
crates/mun_codegen/src/apple.rs 0.00% <0.00%> (ø)
crates/mun_codegen/src/linker.rs 25.33% <0.00%> (-1.43%) ⬇️
crates/mun_target/src/spec/apple_base.rs 69.23% <0.00%> (+9.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72dd828...58ff15c. Read the comment docs.

@baszalmstra baszalmstra merged commit 77f1b01 into mun-lang:main Jan 23, 2022
@baszalmstra baszalmstra added this to the Mun v0.4.0 milestone Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: fix Bug fix or report

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MacOS build fails with unable to find library for -lsystem

2 participants