Skip to content

misc: merge runtime-ffi repository#352

Merged
Wodann merged 7 commits intomun-lang:mainfrom
Wodann:misc/merge-runtime-ffi
Feb 27, 2022
Merged

misc: merge runtime-ffi repository#352
Wodann merged 7 commits intomun-lang:mainfrom
Wodann:misc/merge-runtime-ffi

Conversation

@Wodann
Copy link
Copy Markdown
Collaborator

@Wodann Wodann commented Sep 26, 2021 •
edited
Loading

Merges https://github.com/mun-lang/runtime-ffi into https://github.com/mun-lang/mun, allowing us to archive the former and have a single CI pipleine

@Wodann Wodann requested a review from baszalmstra September 26, 2021 20:06
@Wodann Wodann self-assigned this Sep 26, 2021
@Wodann Wodann force-pushed the misc/merge-runtime-ffi branch 2 times, most recently from 948b76b to 44019ef Compare September 26, 2021 20:15
@baszalmstra
Copy link
Copy Markdown
Collaborator

baszalmstra commented Sep 27, 2021

Will you fix the CI in this PR? Or at a later stage?

You could make the CMake such that if no path is specified for the binaries, than you build them? That way you can always use this repository and we don't have to update the repositories with the binaries! See SixtyFPS for a way how.

@Wodann
Copy link
Copy Markdown
Collaborator Author

Wodann commented Sep 27, 2021

Yeah, I got the notification that CI failed but didn't have time to look at it yet. Will fix!

@Wodann Wodann force-pushed the misc/merge-runtime-ffi branch 3 times, most recently from 586ce50 to 75d701d Compare September 28, 2021 04:46
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 28, 2021 •
edited
Loading

Codecov Report

Merging #352 (5ea9806) into main (37add09) will not change coverage.
The diff coverage is 43.75%.

❗ Current head 5ea9806 differs from pull request most recent head 846919b. Consider uploading reports for the commit 846919b to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #352   +/-   ##
=======================================
  Coverage   82.54%   82.54%           
=======================================
  Files         264      264           
  Lines       15294    15294           
=======================================
  Hits        12624    12624           
  Misses       2670     2670
Impacted Files Coverage Δ
crates/mun_codegen/src/code_gen/symbols.rs 79.14% <0.00%> (ø)
crates/mun_codegen/src/ir.rs 41.66% <ø> (ø)
crates/mun_codegen/src/ir/dispatch_table.rs 80.95% <ø> (ø)
crates/mun_codegen/src/ir/ty.rs 75.19% <0.00%> (ø)
crates/mun_codegen/src/value/function_value.rs 83.33% <50.00%> (ø)
crates/mun_codegen/src/ir/body.rs 81.53% <66.66%> (ø)
crates/mun_codegen/src/intrinsics/macros.rs 100.00% <100.00%> (ø)
crates/tools/src/runtime_capi.rs 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37add09...846919b. Read the comment docs.

@Wodann Wodann force-pushed the misc/merge-runtime-ffi branch 8 times, most recently from bc37a56 to c0bf84b Compare September 28, 2021 06:22
@Wodann Wodann force-pushed the misc/merge-runtime-ffi branch from c0bf84b to 83a60b9 Compare February 21, 2022 19:28
@Wodann
Copy link
Copy Markdown
Collaborator Author

Wodann commented Feb 21, 2022

CI is fixed. Ready to review, @baszalmstra

baszalmstra
baszalmstra reviewed Feb 27, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@baszalmstra baszalmstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase on main? There are still a few LLVM12 changes in here.

@Wodann Wodann force-pushed the misc/merge-runtime-ffi branch from 5ea9806 to c0a904a Compare February 27, 2022 12:58
@Wodann Wodann merged commit 34c3508 into mun-lang:main Feb 27, 2022
@Wodann Wodann deleted the misc/merge-runtime-ffi branch February 27, 2022 13:32
@Wodann Wodann added this to the Mun v0.4.0 milestone Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@baszalmstra baszalmstra baszalmstra approved these changes

Assignees

@Wodann Wodann

Labels

None yet

Projects

None yet

Milestone

Mun v0.4.0

Development

Successfully merging this pull request may close these issues.

2 participants

@Wodann @baszalmstra