refactor: simplified invoke syntax#347
Merged
Wodann merged 2 commits intomun-lang:mainfrom Sep 3, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #347 +/- ##
==========================================
- Coverage 80.21% 80.11% -0.11%
==========================================
Files 262 261 -1
Lines 15667 15703 +36
==========================================
+ Hits 12567 12580 +13
- Misses 3100 3123 +23
Continue to review full report at Codecov.
|
c3ea9e7 to
80610c0
Compare
80610c0 to
59f9fa5
Compare
Wodann
requested changes
Aug 26, 2021
Wodann
approved these changes
Sep 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the invoke syntax of a runtime to be simpler and with less magic.
Previously calling a mun function looked like:
WIth this MR this becomes:
Arguments are passed in as a single tuple. No more macros. A single entry point to call functions which is also properly suggested by language servers and the like. And the code became much simpler. The only downside is that calling a function with a single argument requires a bit of strange rust syntax:
(a,). Note the comma. Without it, the parentheses are seen as an expression instead of a tuple declaration.