Skip to content

bump: rust 1.51.0#325

Merged
baszalmstra merged 1 commit intomun-lang:masterfrom
baszalmstra:bump/rust_1_51_0
May 8, 2021
Merged

bump: rust 1.51.0#325
baszalmstra merged 1 commit intomun-lang:masterfrom
baszalmstra:bump/rust_1_51_0

Conversation

@baszalmstra
Copy link
Copy Markdown
Collaborator

@baszalmstra baszalmstra commented Apr 29, 2021 •
edited
Loading

Bumps Rust to 1.51.0. Also fixes all new warnings and lints.

Biggest changes:

  • Use From instead of Into
  • Use itertools::Itertools::intersperse( instead of .intersperce( because it might be added to std
  • Rename UPPERCASE acronyms to Uppercase.
  • Few more..

Depends on this PRs where some of the naming also had to change:

@baszalmstra baszalmstra added the type: perf Changes that improve performance label Apr 29, 2021
@baszalmstra baszalmstra requested a review from Wodann April 29, 2021 18:01
@baszalmstra baszalmstra self-assigned this Apr 29, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 29, 2021 •
edited
Loading

Codecov Report

Merging #325 (308e494) into master (ba3bdd8) will decrease coverage by 0.01%.
The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #325      +/-   ##
==========================================
- Coverage   80.59%   80.58%   -0.02%     
==========================================
  Files         259      259              
  Lines       15561    15561              
==========================================
- Hits        12542    12540       -2     
- Misses       3019     3021       +2
Impacted Files Coverage Δ
crates/mun_codegen/src/ir/file.rs 100.00% <ø> (ø)
crates/mun_codegen/src/ir/file_group.rs 100.00% <ø> (ø)
crates/mun_codegen/src/value/mod.rs 59.42% <0.00%> (ø)
crates/mun_compiler/src/diagnostics_snippets.rs 84.00% <ø> (ø)
crates/mun_hir/src/diagnostics.rs 64.83% <ø> (ø)
crates/mun_hir/src/package_defs/collector.rs 82.32% <ø> (ø)
crates/mun_language_server/src/completion.rs 87.50% <0.00%> (ø)
crates/mun_memory/src/gc/root_ptr.rs 63.15% <0.00%> (ø)
crates/mun_skeptic/src/lib.rs 0.00% <0.00%> (ø)
crates/mun_syntax/src/syntax_kind/generated.rs 67.74% <ø> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba3bdd8...308e494. Read the comment docs.

@baszalmstra baszalmstra merged commit 72dfbe2 into mun-lang:master May 8, 2021
@Wodann Wodann added this to the Mun v0.4.0 milestone Dec 5, 2022
@Wodann Wodann added type: build Changes that affect the build system or external dependencies and removed type: perf Changes that improve performance labels Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Wodann Wodann Wodann approved these changes

Assignees

@baszalmstra baszalmstra

Labels

type: build Changes that affect the build system or external dependencies

Projects

None yet

Milestone

Mun v0.4.0

Development

Successfully merging this pull request may close these issues.

2 participants

@baszalmstra @Wodann