feat: derive clone for RootedStruct#323
Merged
baszalmstra merged 1 commit intomun-lang:masterfrom May 8, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #323 +/- ##
==========================================
- Coverage 80.59% 80.59% -0.01%
==========================================
Files 259 259
Lines 15561 15561
==========================================
- Hits 12542 12541 -1
- Misses 3019 3020 +1
Continue to review full report at Codecov.
|
Wodann
approved these changes
Apr 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Derive
CloneforRootedStruct. All types contained in theRootedStructalready properly support rooting so this was trivial.The
Clone::clonefunction for aRootedStructclones the references to the struct instead of the contents of the struct. Is that desirable? I think so because to me it would make more sense to have to clone the struct itself in Mun and return a new rooted struct.