Feature/complete grains at shape edge#335
Merged
JonathanMaes merged 7 commits into3.11from Oct 4, 2024
Merged
Conversation
Contributor
Author
|
One of the functions (shufflecells) in make3dgrains used rand.perm to shuffle the cells around before assigning them a region number. This function used the global random generator, which as of go 1.20 is seeded automatically and therefore gives a different output for every run. I've replaced this with the seeded generator of the tessellation to have a deterministic output. I've adapted the test problem to reflect the newly obtained values (the previous test values were obtained with a go version <1.20 which was still deterministic) |
JonathanMaes
approved these changes
Oct 4, 2024
MathieuMoalic
added a commit
to MathieuMoalic/amumax
that referenced
this pull request
Oct 4, 2024
Closed
MathieuMoalic
added a commit
to MathieuMoalic/amumax
that referenced
this pull request
Nov 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a variable to ext_make3dgrains to complete all voronoi grains whose centre lies within the shape. This also cuts away parts of the shape whose closest voronoi centre lies outside the shape.
This allows e.g. to make polycrystalline geometries consisting of clustered individual grains.