Fix shifted quantity for shifts in more than one direction#283
Merged
JonathanMaes merged 2 commits into3.11from Sep 23, 2024
Merged
Fix shifted quantity for shifts in more than one direction#283JonathanMaes merged 2 commits into3.11from
JonathanMaes merged 2 commits into3.11from
Conversation
Contributor
|
@JeroenMulkers Are unit tests possible for this one? |
Collaborator
Author
|
@godsic , I wrote a test in GO because it was too cumbersome to write a decent test in a mumax3 input script. The test fails without the bug fix from this PR. |
JLeliaert
approved these changes
Feb 12, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Shifted quantity could not be used to shift quantities over more than one direction at once. This PR fixes this issue.