Merged
Conversation
The Slonczewski torque depends on the thickness of the free layer. Before this commit, this value was deduced from the thickness of the mesh. There could be cases in which this is not what the user wants. The changes made in this commit allow the user to set the free layer thickness by hand through the "FreeLayerThickness" regionwise parameter. If FreeLayerThickness is set to zero (the default), then the thickness will be deduced from the thickness of the mesh, ensuring backwards compatibility.
JLeliaert
reviewed
Aug 6, 2020
Contributor
JLeliaert
left a comment
There was a problem hiding this comment.
Works as intended in a testcase where the dynamics are simulated with and without a spacer layer. Previously the spacer layer gave rise to erroneous results by also being included in the freelayerthickness. This is now mitigated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Slonczewski torque depends on the thickness of the free layer.
Before this commit, this value was deduced from the thickness of the
mesh. There could be cases in which this is not what the user wants.
The changes made in this commit allow the user to set the free layer
thickness by hand through the "FreeLayerThickness" regionwise parameter.
If FreeLayerThickness is set to zero (the default), then the thickness
will be deduced from the thickness of the mesh, ensuring backwards
compatibility.