Merged
Conversation
Contributor
|
Why are there xuebing commits as well? |
Contributor
Author
|
These are just additions to the the benchmark files. I suspect he accidentally asked for a merge request in this branch instead of master. Anyhow, they cannot break anything, so I merged them |
Contributor
|
@JLeliaert lets split the pull requests, so could you please reset to 2ae01e4 ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When compiling the binaries for older CUDA versions I noticed that mumax does not print the CUDA version actually used, but that cu_GetDriverVersion, actually prints the highest CUDA version supported by the driver. Was this intentional? If not, these changes allow mumax to print the actual CUDA version.