-
Notifications
You must be signed in to change notification settings - Fork 61
Closed
Description
The discussion for how we can stabilize the API of this crate takes place here: #259.
This issue is here to track our progress and link to relevant tasks.
Tasks:
- Split crate into
multihash,multihash-codetableandmultihash-derive#266 - Make
Erroran opaque type - Export
MultihashasMultihashinstead ofMultihashGeneric - Rename custom-derive to
MultihashDigest: Derives are conventionally named after the trait they implement - Rename
serde-codecfeature to serde: Use package renames instead - Remove
parity-scale-codecdependency? Has a large API surface and is already on major version 3. Doesn't seem to be trust-worthy to not break our API in the future again. - Remove
write_multihashandread_multihashfrom the public API: They are already exposed viaMultihash::readandMultihash::write - Rename
arbfeature toquickcheck: More conventional
The above list are suggestions. Happy to debate all of them. The thinking was:
- Reduce and harden API surface
- Minimize dependencies
- Follow ecosystem conventions
Overall, my suggestion would be to pack all of these into one breaking change which will hopefully be the last one for a long time.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels