Skip to content

Add reserved code /#104

Merged
rvagg merged 2 commits intomultiformats:masterfrom
ben221199:master
Aug 11, 2022
Merged

Add reserved code /#104
rvagg merged 2 commits intomultiformats:masterfrom
ben221199:master

Conversation

@ben221199
Copy link
Copy Markdown
Contributor

The code / is used by multiaddr, so it seems reasonable to me to reserve this character.

For example, if there could be a data structure like this:

{
	"address": "<value>"
}

The <value> could be:

  • QmYyQSo1c1Ym7orWxLYvCrM2EmxFTANf8wXmmE7DWjhx5N
  • 12D3KooWD3eckifWpRn9wQpMG9R9hX3sD158z7EqHWmweQAJU5SA
  • bafzaajaiaejcal72gwuz2or47oyxxn6b3rkwdmmkrxgkjxzy3rqt5kczyn7lcm3l

But this could maybe also the value:

  • /ipfs/QmYyQSo1c1Ym7orWxLYvCrM2EmxFTANf8wXmmE7DWjhx5N

@rvagg
Copy link
Copy Markdown
Member

rvagg commented Aug 8, 2022

yeah, this might not be a terrible idea, at least so we have a prompt to consider carefully if we ever want to add a / multibase prefix.

@mxinden @marten-seemann any objections or input?

@mxinden
Copy link
Copy Markdown
Member

mxinden commented Aug 10, 2022

@mxinden @marten-seemann any objections or input?

No objections from my end. Maybe @lidel has thoughts on this.

@ben221199
Copy link
Copy Markdown
Contributor Author

I think multiformats/multiformats#63 is also relevant here in some way.

@marten-seemann
Copy link
Copy Markdown

No objections, but I don't feel confident enough to give an approval.

@ben221199
Copy link
Copy Markdown
Contributor Author

What can I do to make it confident enough for an approval?

Copy link
Copy Markdown
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no harm in reserving it, it'll save potential future pain if we accidentally allocate a multibase with / that's not related to multiaddr, and if we decide somehow to add one then we can undo the reservation but it'd be an intentional thing

@rvagg rvagg merged commit 01dfd87 into multiformats:master Aug 11, 2022
@ben221199 ben221199 deleted the master branch August 12, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants