This repository was archived by the owner on Aug 24, 2021. It is now read-only.
Merged
Conversation
rvagg
approved these changes
Jan 12, 2021
Member
rvagg
left a comment
There was a problem hiding this comment.
mostly just type-related questions above for my own education, and one dead-code block
test/index.spec.js
Outdated
|
|
||
| expect( | ||
| mh.coerceCode(names[name]) | ||
| mh.coerceCode(/** @type {HashCode} */(names[/** @type {HashName} */(name)])) |
Member
There was a problem hiding this comment.
why aren't both of these things being inherited naturally from the typedef for name since there's a clear path to name and therefore names[name]?
Member
Author
There was a problem hiding this comment.
because TS is dumb and name in for in has string type. @Gozala can we improve this ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.