Support buffer with any byteOffset values instead of 0#146
Closed
twoeths wants to merge 1 commit intomultiformats:masterfrom
Closed
Support buffer with any byteOffset values instead of 0#146twoeths wants to merge 1 commit intomultiformats:masterfrom
twoeths wants to merge 1 commit intomultiformats:masterfrom
Conversation
Contributor
|
@tuyennhv thanks for the fix! Could you please add a test case that will ensure this will not regress in the future ? |
Member
|
@Gozala any update on this? Is this still relevant? |
Contributor
It is still relevant as it solves actual bug, I think we still should write a test to avoid regressing this, however maybe we can land this and then (never) add test it in a followup PR. |
Contributor
|
close in favor of #201 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Got an issue when save port to a Buffer and use
convert.toString()to get it back, it turns out multiaddr only expect a Buffer with 0 byte offset, this should support all types of Buffer.