Feat/variable hash functions testing#160
Closed
laudiacay wants to merge 5 commits intomultiformats:masterfrom
Closed
Feat/variable hash functions testing#160laudiacay wants to merge 5 commits intomultiformats:masterfrom
laudiacay wants to merge 5 commits intomultiformats:masterfrom
Conversation
0f07b0e to
d2d9cdb
Compare
aschmahmann
reviewed
Jul 28, 2022
b1c4139 to
d2d9cdb
Compare
This makes it possible to register hasher factories that take a size hint. Such hashers should produce at least the requested number of bytes, but may: 1. Produce fewer bytes in some cases (e.g., not enough input is available). 2. May produce more bytes (the usual case). The caller should check the size of the produced digest to determine if it's sufficient for the caller's use-case (likely truncating it if it's too large). NOTE: the convenience `Sum` function will handle size verification and truncation internally.
d2d9cdb to
2b07b16
Compare
2b07b16 to
4f44f4a
Compare
Contributor
Author
|
Makes sense- it’s right now right?
…On Thu, Jul 28, 2022 at 5:05 PM Jorropo ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In go.mod
<#160 (comment)>
:
> @@ -1,4 +1,4 @@
-module github.com/multiformats/go-multihash
+module github.com/laudiacay/go-multihash
@laudiacay <https://github.com/laudiacay> replace check against the
original name of the module, not the replaced one.
So if I do
replace github.com/multiformats/go-multihash => github.com/laudiacay/go-multihash version
github.com/laudiacay/go-multihash's module name need to be
github.com/multiformats/go-multihash.
Also this is temporary while the PRs are in flight to see CI pass, whoever
is merging this is gonna make new versions, remove the replaces with proper
version bumps.
—
Reply to this email directly, view it on GitHub
<#160 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACDPMJAD5DVSXRYBPEQNP7LVWKOUPANCNFSM5445PALA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Jorropo
requested changes
Aug 3, 2022
Contributor
Jorropo
left a comment
There was a problem hiding this comment.
Small details left to solve. 🙂
Co-authored-by: Jorropo <jorropo.pgm@gmail.com>
Co-authored-by: Jorropo <jorropo.pgm@gmail.com>
d62b0eb to
c7de973
Compare
Contributor
|
replaced with #161 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds tests, audits errors, and checks over docs to merge this. Also bumps the version.