feat: add two filecoin hashes, without Sum() implementations#128
Merged
Stebalien merged 1 commit intomultiformats:masterfrom May 12, 2020
Merged
feat: add two filecoin hashes, without Sum() implementations#128Stebalien merged 1 commit intomultiformats:masterfrom
Stebalien merged 1 commit intomultiformats:masterfrom
Conversation
* sha2-256-trunc254-padded * poseidon-bls12_381-a2-fc1 Ref: multiformats/multicodec#161 Ref: multiformats/multicodec#171 Ref: multiformats/multicodec#170
Stebalien
reviewed
May 12, 2020
Member
Stebalien
left a comment
There was a problem hiding this comment.
Could we add a test to make sure this doesn't crash?
Member
Author
|
@Stebalien there's a couple of entries in |
Stebalien
approved these changes
May 12, 2020
Member
|
Hm. Looking a the implementation, there's no way this is a problem. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: multiformats/multicodec#161
Ref: multiformats/multicodec#171
Ref: multiformats/multicodec#170