absorb go-maddr-filter; rm stale Makefile targets; upgrade deps#124
Merged
absorb go-maddr-filter; rm stale Makefile targets; upgrade deps#124
Conversation
1 task
Stebalien
approved these changes
May 14, 2020
Member
Stebalien
left a comment
There was a problem hiding this comment.
If we're planning on completely deprecating this package in favor of the connection gating logic, this may not be worth it.
I'd also consider making this a sub-package, but have no strong preference.
Otherwise, LGTM.
Member
|
Hm. I regret not having a strong preference. Having random multiaddr filter types in the root package is annoying. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deprecation PR at go-maddr-filter is at: libp2p/go-maddr-filter#23. Once this is merged, I will make a release, update the gomod on the other end, merge that PR, and make a release there.
Also:
Context: libp2p/go-libp2p#829