Lock down multicodec table.csv until there is governance for it#53
Lock down multicodec table.csv until there is governance for it#53galargh merged 1 commit intomultiformats:masterfrom
Conversation
|
Before merge, verify that all the following plans are correct. They will be applied as-is after the merge. Terraform plansmultiformats |
rvagg
left a comment
There was a problem hiding this comment.
yeah, this is pretty minimal, admin+stewards is already an overly-broad group so this isn't even locking down much, and tbh it's not really going to change how the repo has been managed for the last couple of years.
vmx
left a comment
There was a problem hiding this comment.
It's good to see that the discussion about governance is starting, it's something that I wanted to see for years.
|
FYI, only members of github-mgmt stewards team can merge the PRs in this repo. Since there are 2 approves here already, I'm going to do it. |
|
On 22/11/2022 00:05, Rod Vagg wrote:
yeah, this is pretty minimal, admin+stewards is already an overly-broad
group so this isn't even locking down much, and tbh it's not really
going to change how the repo has been managed for the last couple of years.
Yeah — I tried to think about better options. I don't know the space
well enough to trim down admin+stewards myself just yet. One alternative
is to lock this down to just one person or to a small list, and possibly
also add a mention in the readme that the table is frozen for now. The
repo doesn't get updated that frequently, so it's manageable.
…--
Robin Berjon
Governance & Standards at Protocol Labs
https://berjon.com/
|
|
this seems like not the actually intended behavior and i'd like to limit this to protection of the main branch. Push access means i can't directly make a PR to start a discussion. I don't think that's the intention and what you want for now is more limited approval for actually merging things. It isn't sustainable to say we won't allow discussion / include any updated protocols for months at a time - the alternative is that people will continue allocating codecs that make sense without contributing them or having the discussion here. |
|
@galargh could you help us with the settings to just protect merges into the main branch for now, then it's not so important who has branch access? I guess something similar to what's going on in go-car now might be appropriate and it looks like we have a bunch of settings to enable here to make that happen. Alternatively, give me some pointers and I'll put up a PR. |
|
I just enabled a more fine-grained configuration of branch protection rules in this repo. Here's the current config for master protection of multicodecs: github-mgmt/github/multiformats.yml Lines 1055 to 1070 in c677062 Now you can modify them through a PR 🎉 |
|
Please also add back the |
|
I think #67 gets us to where we want to be |
Summary
At the 2022-11-10 IPFS Implementers Sync, the decision was made to lock the multicodec
table.csvuntil we design some governance for it.This change removes push access from the Go and JS Teams.
Why do you need this?
We are working towards standardising multi* and that includes standardising a registry from that table. We need to avoid the proliferation of registrations, and ideally carry out some amount of cleanup, and build up governance for it. The first step is to lock it down. Admins can still make changes if absolutely necessary.
What else do we need to know?
This is my first change here, so it may be wrong, and I am new to the community which means I may be committing a woefully inappropriate faux-pas. #YOLO
DRI: myself
Reviewer's Checklist