Ensure cmake-compiled libraries aren't installed with an rpath #531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The CI failure appears to be a transient issue caused by network availability; I've force-pushed to re-trigger CI. |
97573b7 to
40b6d5f
Compare
40b6d5f to
d63718c
Compare
Collaborator
|
Thanks @freakboy3742 |
Collaborator
Could you link to something showing this theory? In practice, I find that this change does actually make a difference. See #537 for a demonstration and my suggestion to revert this. |
Contributor
Author
|
@radarhere I'll take the conversation to #537 so the context of any revert isn't lost. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default behavior of cmake is to build and install a library with the library's install_name set to
@rpath/libname.dylib. While this is a good default when the library is being used in an executable, it's a problem on macOS when the library is being used as a dependency in a wheel, because the@rpathcan't be resolved as part of the delocate process.Libraries build with autotools/configure (or manually constructed makefiles) aren't affected by this; their default install name is the full install path unless specifically configured with an installation name.
The libblosc build instruction already included a workaround to explicitly set the library identifiers; it's possible to replace that workaround with an explicit cmake configuration.
In addition, the
CMAKE_INSTALL_LIBDIRvalue used for libjpeg-turbo is redundant, as the/libsuffix will be implied from theCMAKE_INSTALL_PREFIXvalue.