[system] Remove css utility in favor of sx#23454
Merged
Conversation
|
@material-ui/system: parsed: -2.96% 😍, gzip: -2.18% 😍 |
oliviertassinari
approved these changes
Nov 9, 2020
Member
Author
@oliviertassinari for the deprecation should we just rename the prop and support both |
Member
|
@mnajdova For the deprecation, this plan sounds good. |
42 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking changes
cssprop withsxto avoid collision with styled-components & emotion CSS props.This PR removes the system's
cssutility in favor ofsx. Both styled-components as well as emotion export their own css prop, which is conflicting with the system one. As we already have thesxprop we can safely remove thecssone in favor ofsx.Closes #18962