[Accordion] Normalize focusVisible logic#22567
Merged
oliviertassinari merged 1 commit intomui:nextfrom Sep 12, 2020
Merged
Conversation
25c96d2 to
d6772d6
Compare
d6772d6 to
3080abf
Compare
eps1lon
approved these changes
Sep 12, 2020
42 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This approach is already used in: PaginationItem, Button, ListItem. Hopefully, it will avoid bugs and is more bundle size efficient
Breaking changes
[Accordion] Rename
focusedtofocusVisiblefor consistency:<Accordion classes={{ - focused: 'custom-focus-visible-classname', + focusVisible: 'custom-focus-visible-classname', }} />