Merged
Conversation
oliviertassinari
approved these changes
Aug 13, 2020
42 tasks
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
breaking change
re-enabling the restore focus logic while
openby flippingdisableRestoreFocusfromtruetofalseno longer has an effect. It only worked ifdisableRestoreFocuswas flipped in a separate commit but not ifdisableRestoreFocusandopenwhere flipped.The current usage started with the old lifecycle model but started to add dependencies that weren't used by some effects. Effects should each live in their own
useEffectnot one singlecomponentDidMount.The tests introduced in this PR fail on
next. Onlyundesired: setting disableRestoreFocus to false before closing has no effecthad the desired behavior onnext. I think I can make this use case work though.This PR is part of the changes required to make this component work with React 17. Entangling the effects makes it easier to reason about the behavior. In the end I don't think it's viable to run the restore focus logic in the cleanup. I need a codesandbox to experiment with it though.