[Pagination] Rename round -> circular for consistency#22009
Merged
oliviertassinari merged 3 commits intomui:nextfrom Aug 1, 2020
Merged
[Pagination] Rename round -> circular for consistency#22009oliviertassinari merged 3 commits intomui:nextfrom
oliviertassinari merged 3 commits intomui:nextfrom
Conversation
eps1lon
approved these changes
Aug 1, 2020
Member
|
@kodai3 Well done |
42 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking changes
Pagination
Rename
roundtocircularfor consistency. The possible values should be adjectives, not nouns:PaginationItem
Rename
roundtocircularfor consistency. The possible values should be adjectives, not nouns:One item of #21964
I changed two components on 1PR,because
Paginationdepend onPaginationItemby functionrenderItem