[core] Drop support for non-ref-forwarding class components#21811
Merged
[core] Drop support for non-ref-forwarding class components#21811
Conversation
|
@material-ui/core: parsed: -0.39% 😍, gzip: -0.61% 😍 |
7d43c97 to
54f2f1b
Compare
joshwooding
approved these changes
Jul 16, 2020
Member
oliviertassinari
left a comment
There was a problem hiding this comment.
It feels great to get ride of this logic
7 tasks
2 tasks
Closed
2 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Class components not forwarding their ref to the underlying DOM (or host) component are no longer supported. If you were using
unstable_createStrictModeThemeor didn't see any StrictMode warnings regardingfindDOMNodethen this change is not breaking.unstable_createStrictModeThemestays for now as a no-op in case we need it again during v5 development.Has a deprecation in place (via StrictMode).
TODO:
[ ] revisitUpdating these in a follow-upStrictModeViolationcomments