[Button] Make primary the default color#21594
Merged
oliviertassinari merged 10 commits intomui:nextfrom Jun 30, 2020
mbrookes:button-color-deprecate-default
Merged
[Button] Make primary the default color#21594oliviertassinari merged 10 commits intomui:nextfrom mbrookes:button-color-deprecate-default
oliviertassinari merged 10 commits intomui:nextfrom
mbrookes:button-color-deprecate-default
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
oliviertassinari
requested changes
Jun 28, 2020
Member
Author
It was done already: |
Comment on lines
+65
to
+67
| ``` | ||
| /(<Button(\n*.*?)*?)color="primary"/$1/g | ||
| ``` |
Member
Author
There was a problem hiding this comment.
It's a regex (in Vim search and replace format) that removes color="primary" from Buttons.
Member
There was a problem hiding this comment.
Ok, maybe we should explain? I don't know how to use it. Do we have something that can work with VScode?
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
oliviertassinari
approved these changes
Jun 28, 2020
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
mbrookes
commented
Jun 28, 2020
Member
|
We have missed this regression. @mbrookes Could you have a look? :) |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
colorprop is now "primary" by default, and "default" has been removed. This makes the button closer to the Material Design specification and simplifies the API.Closes #17530