Conversation
| @@ -1,8 +0,0 @@ | |||
| module.exports = { | |||
There was a problem hiding this comment.
We prefer to use the overrides key of the main eslint file. This ensures we can see all the rules at the same place. In our case, it seems we don't need this file at all.
|
@dtassone I need your help to fix the reported errors. I believe they are all relevant. If you see one you don't agree with, we can discuss it. |
| "lint:ci": "eslint . --report-unused-disable-directives", | ||
| "lint:fix": "eslint . --cache --fix" | ||
| "lint": "eslint . --cache --report-unused-disable-directives --ext .ts,.tsx", | ||
| "lint:ci": "eslint . --report-unused-disable-directives --ext .ts,.tsx", |
There was a problem hiding this comment.
The important change
|
Did you run the new lint conf on the repo? |
#60 (comment). It also aims to show that the diff works, the CI should be failing without the fixes, it's the mandatory first step. |
Ok I will check out this branch, fix the lint errors, and update asap |
|
Closing, we will need to restart from mui/material-ui#21758 |
I have forgotten to tell eslint to lint the ts and tsx files. I will bring this change back to the main repository, we will need it there too.