Skip to content

[DropDownMenu] Add keyboard accessibility#5921

Merged
oliviertassinari merged 1 commit intomui:masterfrom
oliviertassinari:dropdown-keyboard-support
Jan 14, 2017
Merged

[DropDownMenu] Add keyboard accessibility#5921
oliviertassinari merged 1 commit intomui:masterfrom
oliviertassinari:dropdown-keyboard-support

Conversation

@oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jan 12, 2017

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

This is a continuation of #4966
Thanks @caesay for the original PR.
It would be awesome if you could have a look at it, same for @petermikitsh.

Closes #4966.
Closes #5498.

@patrickml
Copy link

<3 Awesome, does this happen to also fix using the tab key to move to the next input?

@oliviertassinari
Copy link
Member Author

@patrickml Yes, it does. That's the all goal of that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accessibility a11y type: bug It doesn't behave as expected.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants