[base-ui] Update props using Array to ReadonlyArray type#40754
Merged
ZeeshanTamboli merged 5 commits intomui:masterfrom Feb 7, 2024
Merged
[base-ui] Update props using Array to ReadonlyArray type#40754ZeeshanTamboli merged 5 commits intomui:masterfrom
ZeeshanTamboli merged 5 commits intomui:masterfrom
Conversation
Netlify deploy previewhttps://deploy-preview-40754--material-ui.netlify.app/ Bundle size report |
Member
|
Hey @RaghavenderSingh, thanks for working on this 😊. Before reviewing, please fix the failing build checks. |
Contributor
Author
Yea sure will fix the failing build checks. |
Member
2 tasks
michaldudak
reviewed
Jan 29, 2024
Member
michaldudak
left a comment
There was a problem hiding this comment.
There are couple more occurrences of a mutable arrays in Base UI that could be changed to ReadonlyArray. Search for [] in ./packages/mui-base/**/*.types.ts
Member
|
@michaldudak Since the PR author isn't active, I've made the changes myself. Could you review? |
This was referenced Feb 7, 2024
This was referenced May 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have followed (at least) the PR section of the contributing guide.
Replaced Array API with ReadonlyArray
Closes #40750