[ButtonGroup] Fix rendering with conditional elements#38989
Merged
ZeeshanTamboli merged 9 commits intomui:masterfrom Oct 4, 2023
Merged
Conversation
Netlify deploy previewhttps://deploy-preview-38989--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
2 tasks
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Member
Not sure about this one, @mnajdova what do you think? |
DiegoAndai
requested changes
Sep 15, 2023
Member
|
The code looks good, we don't need to include the source of where we copied it, it's not likely that we will need to backport changes in the future. The util itself looks good |
DiegoAndai
approved these changes
Sep 29, 2023
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #38978
Before: https://stackblitz.com/edit/stackblitz-starters-nykpki
After: https://codesandbox.io/s/material-ui-cra-ts-forked-4xh5j7
The issue arises for conditional elements because
React.Children.count(childrenParam) also counts empty nodes, causing problems with applying the wrong positioning classes and thus resulting in incorrect styling. To avoid this, we can useReact.Children.toArray, which excludes empty nodes.I've also created a utility method to get valid React elements which is directly copied from Chakra UI source code (let me know if this is fine) so that it can be reused in other MUI packages.
(Note: This bug is also present in Joy UI ButtonGroup component.)