Merged
Conversation
579986a to
c7a2a58
Compare
mnajdova
reviewed
Sep 16, 2021
mnajdova
approved these changes
Sep 16, 2021
Member
mnajdova
left a comment
There was a problem hiding this comment.
I have just one question, the other changes look good!
ce135b8 to
015b442
Compare
eps1lon
reviewed
Sep 16, 2021
eps1lon
reviewed
Sep 16, 2021
| https://next.material-ui.com/* https://mui.com/:splat 301! | ||
|
|
||
| # Support multiple domains | ||
| https://material-ui.dev/* https://mui.com/:splat 301! |
Member
There was a problem hiding this comment.
This also wouldn't have worked without material-ui.dev being setup as an alias domain on netlify:
For Netlify to redirect from a domain that is not the site’s main custom domain, the domain must be assigned to the site — probably as a domain alias or a branch subdomain.
-- https://docs.netlify.com/routing/redirects/redirect-options/#domain-level-redirects
Member
Author
There was a problem hiding this comment.
It used to be, I removed it about two months ago. It's a cleanup.
eps1lon
approved these changes
Sep 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have pushed one commit, with a description sometimes to get a more granular level of "why"