[Tooltip] Ensure user-select CSS property is reverted after touch end#28372
Merged
eps1lon merged 3 commits intomui:masterfrom Sep 16, 2021
tholman:tooltip-user-select-revert-after-press
Merged
[Tooltip] Ensure user-select CSS property is reverted after touch end#28372eps1lon merged 3 commits intomui:masterfrom tholman:tooltip-user-select-revert-after-press
user-select CSS property is reverted after touch end#28372eps1lon merged 3 commits intomui:masterfrom
tholman:tooltip-user-select-revert-after-press
Conversation
eps1lon
approved these changes
Sep 16, 2021
Member
eps1lon
left a comment
There was a problem hiding this comment.
Thanks for the detailed context and great test. Much appreciated!
user-select CSS property is reverted after touch end
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if you tap on a button within a tooltip on mobile (safari/chrome) the user select will be set to 'none', the
handleTouchEndfunction will remove the touchtimer from the touch start, so the user select ‘none’ will now be left on for the rest of the session.Demo of the bug here (bug exists in current mui and 5 rc), https://codesandbox.io/s/usage-forked-vow1z?file=/index.js ... if you go to the resolved window on chrome and use a mobile view to trigger event by "tapping" the button, you will see that you can no longer select the text in the document.