Skip to content

[system] Fix missing typings for createSpacing#28361

Merged
eps1lon merged 2 commits intomui:masterfrom
eps1lon:core/fix/repeated-builds
Sep 15, 2021
Merged

[system] Fix missing typings for createSpacing#28361
eps1lon merged 2 commits intomui:masterfrom
eps1lon:core/fix/repeated-builds

Conversation

@eps1lon
Copy link
Member

@eps1lon eps1lon commented Sep 15, 2021

Closes #28359 (though I do not fully understand why. I still suspect #28359 is just a race condition.)

@eps1lon eps1lon added type: bug It doesn't behave as expected. typescript scope: system The system, the design tokens / styling foundations used across components. eg. @mui/system with MUI labels Sep 15, 2021
"rootDir": "./src"
},
"include": ["src/**/*.ts"],
"include": ["src/**/*.ts*"],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by change for future compat

@mui-pr-bot
Copy link

mui-pr-bot commented Sep 15, 2021

No bundle size changes

Generated by 🚫 dangerJS against 03f32e4

@eps1lon eps1lon marked this pull request as ready for review September 15, 2021 14:10
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to fix the issue. Thanks.

@eps1lon eps1lon merged commit d853515 into mui:master Sep 15, 2021
@eps1lon eps1lon deleted the core/fix/repeated-builds branch September 15, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: system The system, the design tokens / styling foundations used across components. eg. @mui/system with MUI type: bug It doesn't behave as expected. typescript

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[core] Running release:build twice causes errors

3 participants