[docs] Fix failing client-side navigation for /api routes#28356
Merged
eps1lon merged 2 commits intomui:masterfrom Sep 15, 2021
Merged
[docs] Fix failing client-side navigation for /api routes#28356eps1lon merged 2 commits intomui:masterfrom
eps1lon merged 2 commits intomui:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Next.js previously fell back to basic URL navigation (opposed to client-side routing) for links to
/apiroutes that were rendered via markdown.Compare clicking on the "InputBase" link in "Props of the InputBase component are also available." on https://613f2e53d5823400073263e4--material-ui.netlify.app/api/outlined-input/ vs https://deploy-preview-28356--material-ui.netlify.app//api/outlined-input/
I previously thought
rewriteswas just not working for client-side navigation (#23586). Turns out it's just bugged when the rewrite doesn't have a trailing slash withtrailingSlash: true(vercel/next.js#25673, vercel/next.js#25104, vercel/next.js#20984).We can probably revert most #23586 but I'm not sure how the data-grid
api-docsrewrites work so I'm rather not touch it.