[website] Rename domain to mui.com by mnajdova · Pull Request #28332 · mui/material-ui

mnajdova · 2021-09-14T11:06:59Z

Questions:

Should we update the netlify instance to publish on the new domain?
Are the _redirects update correct?

Other things to do:

Publish the previous versions to v[version].mui.com?
Update the medium blog post links to point to https://mui.com?
Run a SEO crawler once done and fix all the issues coming
else?

mui-pr-bot · 2021-09-14T11:08:52Z

Details of bundle changes

Generated by 🚫 dangerJS against 3eafe0b

mnajdova · 2021-09-14T11:37:17Z

docs/public/_redirects

-/v0.3.2 https://v0.material-ui.com/v0.3.2
-/v0.3.1 https://v0.material-ui.com/v0.3.1
-/v0.3.0 https://v0.material-ui.com/v0.3.0
+/v0.20.0 https://v0.mui.com/v0.20.0


Should we remove these?

We could, but likely in a different PR for history revision.

mnajdova · 2021-09-14T11:37:40Z

docs/public/_redirects

 /customization/themes/ /customization/theming/ 301
-https://v1-5-0.material-ui.com/* https://v1.material-ui.com/:splat 301!
-https://v3-9-0.material-ui.com/* https://v3.material-ui.com/:splat 301!
+https://v1-5-0.mui.com/* https://v1.mui.com/:splat 301!


Should we remove these?

No objections, the context: #16541, likely in a different PR. And likely we need to do the same for some of the v4 versions.

Alright, will do it in a dedicated PR after the stable release.

mnajdova · 2021-09-14T11:38:48Z

_redirects

## material-ui-x
## Unlike the store that expect to be hosted under a subfolder,
## material-ui-x is configured to be hosted at the root.
/api/*/ https://docs-v5--material-ui-x.netlify.app/api/:splat/ 200
/:lang/api/*/ https://docs-v5--material-ui-x.netlify.app/:lang/api/:splat/ 200
/components/* https://docs-v5--material-ui-x.netlify.app/components/:splat 200
/:lang/components/* https://docs-v5--material-ui-x.netlify.app/:lang/components/:splat 200
/_next/* https://docs-v5--material-ui-x.netlify.app/_next/:splat 200
/static/x/* https://docs-v5--material-ui-x.netlify.app/static/x/:splat 200

These look suspicious. Should we change them before going live?

eps1lon · 2021-09-14T11:43:22Z

Olivier has to say something about the redirects. I'm not familiar with most of these.

Though I can revert the changes to translated markdown files

$ git checkout master -- '*-de.md'
$ git checkout master -- '*-es.md'
# etc.

m4theushw · 2021-09-14T13:25:25Z

These look suspicious. Should we change them before going live?

These redirects are for the v5 docs of the DataGrid. Once we release v5.0.0-beta.0 this week, it will have the same look of the core v5 docs. Previously, we were pointing to https://next--material-ui-x.netlify.app/, but this is our development branch. Then, I created docs-v5 which will host the deployed docs. This new branch was based on master, so it still has the old look. See #28263

oliviertassinari · 2021-09-14T15:21:55Z

I could find this page on the matter in the search console: https://search.google.com/search-console/settings/change-address?resource_id=sc-domain%3Amaterial-ui.com

For those that don't have access, their "Learn more" points to https://developers.google.com/search/docs/advanced/crawling/site-move-with-url-changes.

oliviertassinari

@mnajdova Looks good

Should we update the netlify instance to publish on the new domain?

I think that we can use the "primary domain" abstraction. In https://app.netlify.com/sites/material-ui-docs/settings/domain

Are the _redirects update correct?

Should we also add a https://material-ui.com/* https://mui.com/:splat 301! redirection?

Publish the previous versions to v[version].mui.com?

This is done automatically by changing the primary domain in Netlify's config.

Update the medium blog post links to point to https://mui.com?

Done. For all the blog posts I could find

Run a SEO crawler once done and fix all the issues coming

We will likely have to wait for being on the main domain

These look suspicious. Should we change them before going live?

@m4theushw Started to answer it. I will complement it by saying that Netlify recommends using the production URL with proxies, it might not work correctly otherwise. We can wait to hit the fan.

oliviertassinari · 2021-09-14T15:37:38Z

docs/public/_redirects

-/v0.3.2 https://v0.material-ui.com/v0.3.2
-/v0.3.1 https://v0.material-ui.com/v0.3.1
-/v0.3.0 https://v0.material-ui.com/v0.3.0
+/v0.20.0 https://v0.mui.com/v0.20.0


We could, but likely in a different PR for history revision.

oliviertassinari · 2021-09-14T15:39:55Z

docs/public/_redirects

 /customization/themes/ /customization/theming/ 301
-https://v1-5-0.material-ui.com/* https://v1.material-ui.com/:splat 301!
-https://v3-9-0.material-ui.com/* https://v3.material-ui.com/:splat 301!
+https://v1-5-0.mui.com/* https://v1.mui.com/:splat 301!


No objections, the context: #16541, likely in a different PR. And likely we need to do the same for some of the v4 versions.

mnajdova · 2021-09-14T21:03:26Z

Should we also add a https://material-ui.com/* https://mui.com/:splat 301! redirection?

I've already added it https://github.com/mui-org/material-ui/pull/28332/files#diff-7a0cbac74402caf0e99ba338a9e7c42684580a1f85e149110c3c2ca6e38055afR14

mnajdova · 2021-09-15T06:32:04Z

@oliviertassinari should we also add the following redirects:

https://v0.material-ui.com/* https://v0.mui.com/:splat 301!
https://v1.material-ui.com/* https://v1.mui.com/:splat 301!
https://v3.material-ui.com/* https://v3.mui.com/:splat 301!
https://v4.material-ui.com/* https://v4.mui.com/:splat 301!

oliviertassinari · 2021-09-15T09:18:50Z

should we also add the following redirects:

@mnajdova Yeah, makes sense 👍

docs/public/_redirects

mnajdova added 3 commits September 14, 2021 12:52

Replace material-ui.como with mui.com

cd7e878

Updated redirects

6394acd

prettier

3fadb05

github-actions bot mentioned this pull request Sep 14, 2021

Update snapshots for pr/28332 eps1lon/mui-scripts-incubator#3116

Closed

mnajdova marked this pull request as ready for review September 14, 2021 11:34

mnajdova requested a review from a team September 14, 2021 11:35

mnajdova commented Sep 14, 2021

View reviewed changes

Revert changes in translation md files

fb88aff

oliviertassinari added the docs Improvements or additions to the documentation. label Sep 14, 2021

oliviertassinari reviewed Sep 14, 2021

View reviewed changes

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Sep 15, 2021

Merge branch 'master' into feat/rename-domain

f08b952

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Sep 15, 2021

mnajdova changed the title ~~[docs] Rename domain to mui.com~~ [website] Rename domain to mui.com Sep 15, 2021

eps1lon approved these changes Sep 15, 2021

View reviewed changes

mnajdova added website Pages that are not documentation-related, marketing-focused. and removed docs Improvements or additions to the documentation. labels Sep 15, 2021

mnajdova commented Sep 15, 2021

View reviewed changes

docs/public/_redirects Show resolved Hide resolved

Update docs/public/_redirects

3eafe0b

oliviertassinari approved these changes Sep 15, 2021

View reviewed changes

mnajdova merged commit 24015d1 into mui:master Sep 15, 2021

Uh oh!

Conversation

mnajdova commented Sep 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mui-pr-bot commented Sep 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mnajdova Sep 14, 2021

Choose a reason for hiding this comment

Uh oh!

oliviertassinari Sep 14, 2021

Choose a reason for hiding this comment

Uh oh!

mnajdova Sep 14, 2021

Choose a reason for hiding this comment

Uh oh!

oliviertassinari Sep 14, 2021

Choose a reason for hiding this comment

Uh oh!

mnajdova Sep 14, 2021

Choose a reason for hiding this comment

Uh oh!

mnajdova commented Sep 14, 2021

Uh oh!

eps1lon commented Sep 14, 2021

Uh oh!

m4theushw commented Sep 14, 2021

Uh oh!

oliviertassinari commented Sep 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oliviertassinari left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

oliviertassinari Sep 14, 2021

Choose a reason for hiding this comment

Uh oh!

oliviertassinari Sep 14, 2021

Choose a reason for hiding this comment

Uh oh!

mnajdova commented Sep 14, 2021

Uh oh!

mnajdova commented Sep 15, 2021

Uh oh!

oliviertassinari commented Sep 15, 2021

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mnajdova commented Sep 14, 2021 •

edited

Loading

mui-pr-bot commented Sep 14, 2021 •

edited

Loading

oliviertassinari commented Sep 14, 2021 •

edited

Loading

oliviertassinari left a comment •

edited

Loading