[docs] Prepare for v4.material-ui.com deploy#28227
Merged
Conversation
Details of bundle changes.Comparing: e544918...5ffa621 Details of page changes
@material-ui/core: parsed: +Infinity% , gzip: +Infinity% |
Member
|
We need to update https://github.com/algolia/docsearch-configs/blob/8c00aefb042ea88edfc342a531aa333ffc38291b/configs/material-ui.json#L6 too for the Algolia search to work. |
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Member
|
Can we already do a deploy of https://v4.material-ui.com/ to test integration? |
Member
Author
Yes, let me do it. |
Member
Author
Created algolia/docsearch-configs#4563 |
Member
Author
|
I've pushed v4 - https://github.com/mui-org/material-ui-docs/tree/v4 How can I trigger a deploy? Or is it going to be deployed automatically? |
Member
Probably need to setup netlify. Maybe https://app.netlify.com/sites/material-ui-docs/settings/domain? |
Member
Author
Yep, updated looks like it started - https://app.netlify.com/sites/material-ui-docs/deploys/6138b75981ce81000735f48d |
Member
Author
|
Actually I should have pushed the current branch so that we can test with these change too 🤦 |
Member
Author
Member
Author
|
Here is the preview: https://6138bd2317673f00085a263d--material-ui-docs.netlify.app/ |
Member
I believe the DNS record is automatically handled by netlify. But DNS records take a while to get propagated. If it isn't available tomorrow, we're missing something. |
Member
Author
|
It’s life https://v4.material-ui.com/ |
Member
|
I feel like we should start marking the affected lines like we do with |
Member
Author
Agree, it's not really straightforward, but on the other hand, it was easy to follow based on what was done in v3. But yes, it may be better if we mark them. After this is successfully merged, I will add above the lines that were changed a comment that can help when we do the next major version. |
eps1lon
approved these changes
Sep 8, 2021
Member
Author
|
One last thing, should we change the v5 banner's link to point to https://material-ui.com instead of https://next.material-ui.com ? |
Member
But |
Member
Author
Yeah, I was going two steps at a time 😄 Alright, going to merge this one, we can iterate if we find something missing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR prepares the deploy for https://v4.material-ui.com
I followed the last three commits from https://github.com/mui-org/material-ui-docs/commits/v3
I hope I haven't missed something important.