[Button] Use deeper imports from unstyled, correct docs#28074
Merged
michaldudak merged 5 commits intomui:nextfrom Sep 8, 2021
Merged
[Button] Use deeper imports from unstyled, correct docs#28074michaldudak merged 5 commits intomui:nextfrom
michaldudak merged 5 commits intomui:nextfrom
Conversation
Member
|
Could we wait for the package rename changes to go in before we merge this one? |
Member
Author
|
Sure, no problem |
Member
|
I think that it fails because of https://github.com/mui-org/material-ui/blob/bbc5561f360985430fc6ef4f81eca0ce093eaf98/packages/material-ui/scripts/rollup.config.js#L85 while we have a .ts file not a .js one. |
Member
Author
|
@oliviertassinari Is there some known workaround or should I try to fix the config? |
Member
|
I guess we need to fix this line. We could test if the ts file is present, return it and default to the .js file if not. |
Member
Author
|
Fixing in #28094 |
Member
oliviertassinari
left a comment
There was a problem hiding this comment.
Looks great, thanks for the follow up.
Member
Author
@oliviertassinari can I have approval, then? 😉 |
Member
Author
|
Thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small corrections discussed in #27600 (review)
Preview https://deploy-preview-28074--material-ui.netlify.app/components/buttons/#unstyled