[DateTimePicker] Change bottom position of AM/PM buttons#27534
Merged
[DateTimePicker] Change bottom position of AM/PM buttons#27534
Conversation
mnajdova
approved these changes
Aug 2, 2021
eps1lon
requested changes
Aug 10, 2021
Member
There was a problem hiding this comment.
Thanks for the work.
Unfortunately, this breaks styles of the ClockPicker (which is used by the TimePicker): https://deploy-preview-27534--material-ui.netlify.app/components/time-picker/#basic-usage
Contributor
Author
|
Didn't notice that, sry. I'll try to fix it and apply for DateTimePicker only, where is Cancel/OK buttons |
eps1lon
approved these changes
Sep 9, 2021
Member
eps1lon
left a comment
There was a problem hiding this comment.
Looks good now without breaking the TimePicker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #25422
AM/PM buttons are aligned at clock bottom line
Preview: https://deploy-preview-27534--material-ui.netlify.app/components/date-time-picker/#main-content
Link to the fixed codesandbox example: https://codesandbox.io/s/basicdatetimepicker-material-demo-forked-soipx?file=/package.json