[test] Migrate regressions to emotion#27010
Conversation
oliviertassinari
left a comment
There was a problem hiding this comment.
We need no visual changes in Argos :)
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
eps1lon
left a comment
There was a problem hiding this comment.
Let's not use too much API surface. Especially most of the sx stuff can be removed. It's unrelated to the test and just frustrating to deal with if it breaks.
|
@eps1lon I think that we have tried to keep the CSS to its minimum in the visual regression tests so far, but there is likely more room for simplification 👍. I would add a note of caution: we added some CSS to create the right environment to reproduce bugs, these will still need to be here. |
Hiding more stuff behind an abstraction (e.g. |
eps1lon
left a comment
There was a problem hiding this comment.
The style -> sx changes should be reverted. sx is unrelated to the tests.
I think it is not clear to me. Should we remove -<Input sx={{ margin: 1 }} />
+<Input style={{ margin: 1 }} />or only for Box components? -<Box sx={{ margin: 1 }} />
+<div style={{ margin: 1 }} /> |
It's not about removing. It's about keeping it the way it is. We just want to migrate the parts that are using |
|
What is missing from this? |
|
Using |
eps1lon
left a comment
There was a problem hiding this comment.
Thanks for sticking with it. Much appreciated.
One of #16947