Skip to content

[IconButton] Remove label span#26801

Merged
siriwatknp merged 3 commits intomui:nextfrom
siriwatknp:fix/icon-button-span
Jun 17, 2021
Merged

[IconButton] Remove label span#26801
siriwatknp merged 3 commits intomui:nextfrom
siriwatknp:fix/icon-button-span

Conversation

@siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Jun 17, 2021 •
edited
Loading

BREAKING CHANGE
span element that wraps children has been removed. label classKey is also removed. More details about this change.

<button class="MuiIconButton-root">
- <span class="MuiIconButton-label">
    <svg />
- </span>
</button>

follow up of #26666

preview 👉 https://deploy-preview-26801--material-ui.netlify.app/components/buttons/#icon-button

@siriwatknp siriwatknp added breaking change Introduces changes that are not backward compatible. scope: icon button Changes related to the icon button. labels Jun 17, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented Jun 17, 2021 •
edited
Loading

Details of bundle changes (experimental)

Generated by 🚫 dangerJS against a082950

siriwatknp
siriwatknp commented Jun 17, 2021
View reviewed changes
docs/src/pages/guides/migration-v4/migration-v4.md Outdated
+ <IconButton size="large">
```

- `span` element that wraps children has been removed. `label` classKey is also removed. Read more about [span removal](https://github.com/mui-org/material-ui/pull/26666).
Copy link
Member Author

@siriwatknp siriwatknp Jun 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think developer might be curious about why it is removed, so link to the description of the PR.

@siriwatknp siriwatknp force-pushed the fix/icon-button-span branch from fc91f2d to a082950 Compare June 17, 2021 03:13
siriwatknp
siriwatknp commented Jun 17, 2021
View reviewed changes
docs/src/pages/guides/migration-v4/migration-v4.md
You can use the [`button-color-prop` codemod](https://github.com/mui-org/material-ui/tree/HEAD/packages/material-ui-codemod#button-color-prop) for automatic migration.

- `span` element that wraps children has been removed. `label` classKey is also removed.
- `span` element that wraps children has been removed. `label` classKey is also removed. More details about [this change](https://github.com/mui-org/material-ui/pull/26666).
Copy link
Member Author

@siriwatknp siriwatknp Jun 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think developer might be curious why it is removed, so I link to the description of the PR.

Copy link
Member

@eps1lon eps1lon Jun 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's really helpful 👍

@siriwatknp siriwatknp mentioned this pull request Jun 17, 2021
Closed
@oliviertassinari oliviertassinari removed their request for review June 17, 2021 11:35
@siriwatknp siriwatknp merged commit 567e6cf into mui:next Jun 17, 2021
@siriwatknp siriwatknp deleted the fix/icon-button-span branch June 17, 2021 13:00
@siriwatknp siriwatknp mentioned this pull request Jun 23, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eps1lon eps1lon eps1lon approved these changes

@mnajdova mnajdova mnajdova approved these changes

Assignees

No one assigned

Labels

breaking change Introduces changes that are not backward compatible. scope: icon button Changes related to the icon button.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@siriwatknp @mui-pr-bot @mnajdova @eps1lon