Skip to content

[theme] Improve default breakpoints#26746

Merged
siriwatknp merged 8 commits intomui:nextfrom
siriwatknp:breakpoints-update
Jun 17, 2021
Merged

[theme] Improve default breakpoints#26746
siriwatknp merged 8 commits intomui:nextfrom
siriwatknp:breakpoints-update

Conversation

@siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Jun 14, 2021 •
edited by oliviertassinari
Loading

close #21902

new default breakpoint

values = {
  xs: 0, // phone
  sm: 600, // tablets
  md: 900, // small laptop
  lg: 1200, // desktop
  xl: 1536, // large screens
},

https://deploy-preview-26746--material-ui.netlify.app/branding/about/

@siriwatknp siriwatknp added design: material This is about Material Design, please involve a visual or UX designer in the process breaking change Introduces changes that are not backward compatible. labels Jun 14, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented Jun 14, 2021 •
edited
Loading

Details of bundle changes (experimental)

Generated by 🚫 dangerJS against f131646

mnajdova
mnajdova reviewed Jun 14, 2021
View reviewed changes
oliviertassinari
oliviertassinari reviewed Jun 14, 2021
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove the custom breakpoints we use for the branding, for the sake of simplicity?

@oliviertassinari oliviertassinari changed the title [theme] update default breakpoints [theme] Improve default breakpoints Jun 14, 2021
oliviertassinari
oliviertassinari reviewed Jun 14, 2021
View reviewed changes
oliviertassinari
oliviertassinari reviewed Jun 15, 2021
View reviewed changes
siriwatknp
siriwatknp commented Jun 15, 2021
View reviewed changes
@github-actions github-actions bot mentioned this pull request Jun 15, 2021
Closed
danilo-leal
danilo-leal approved these changes Jun 16, 2021
View reviewed changes
Copy link
Collaborator

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just took a peek at the discussion and it seems all good to me. Olivier did a great benchmark and it seems like these values get around what everyone is using, even Material Design.

@siriwatknp siriwatknp merged commit e8c3377 into mui:next Jun 17, 2021
@siriwatknp siriwatknp mentioned this pull request Jun 23, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@mnajdova mnajdova Awaiting requested review from mnajdova

+1 more reviewer

@danilo-leal danilo-leal danilo-leal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

breaking change Introduces changes that are not backward compatible. design: material This is about Material Design, please involve a visual or UX designer in the process

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[theme] Improve the breakpoints values

5 participants

@siriwatknp @mui-pr-bot @oliviertassinari @mnajdova @danilo-leal